-
Notifications
You must be signed in to change notification settings - Fork 17
feat(model/qwen3-tts-realtime):support instruct param #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @songguocola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Qwen3 real-time Text-to-Speech service by integrating new instruction-based parameters. The primary goal is to provide users with greater control and flexibility over the TTS output by allowing them to pass specific instructions during session updates. This change expands the API's capabilities without altering existing functionality, ensuring backward compatibility while enabling more sophisticated use cases. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces instructions and optimize_instructions parameters for the qwen_tts_realtime model, allowing for more control over the text-to-speech synthesis. The implementation correctly adds these parameters to the session configuration. While the change is straightforward, the documentation for these new parameters could be more descriptive to aid developers. More importantly, this pull request lacks tests for the new functionality. Adding unit or integration tests is crucial to verify that the new parameters are handled correctly and to prevent future regressions.
| instructions: str | ||
| instructions for tts, default is None | ||
| optimize_instructions: str | ||
| optimize_instructions for tts, default is None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current descriptions for instructions and optimize_instructions are very brief. To help users understand and use these new parameters effectively, please expand the docstrings to include:
- A clear explanation of what each parameter does.
- The expected format or some examples of valid values.
- The distinction between
instructionsandoptimize_instructions.
Clear documentation is essential for API usability.
No description provided.