Skip to content

Conversation

@songguocola
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @songguocola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Qwen3 real-time Text-to-Speech service by integrating new instruction-based parameters. The primary goal is to provide users with greater control and flexibility over the TTS output by allowing them to pass specific instructions during session updates. This change expands the API's capabilities without altering existing functionality, ensuring backward compatibility while enabling more sophisticated use cases.

Highlights

  • New Parameters for Qwen3 TTS: Introduced instructions and optimize_instructions parameters to the update_session method in the Qwen3 real-time Text-to-Speech (TTS) client.
  • Enhanced TTS Control: These new parameters allow users to provide specific instructions for TTS generation, offering more granular control over the audio output.
  • Configuration Integration: The update_session method now conditionally adds these new instruction parameters to the session configuration if they are provided.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces instructions and optimize_instructions parameters for the qwen_tts_realtime model, allowing for more control over the text-to-speech synthesis. The implementation correctly adds these parameters to the session configuration. While the change is straightforward, the documentation for these new parameters could be more descriptive to aid developers. More importantly, this pull request lacks tests for the new functionality. Adding unit or integration tests is crucial to verify that the new parameters are handled correctly and to prevent future regressions.

Comment on lines +211 to +214
instructions: str
instructions for tts, default is None
optimize_instructions: str
optimize_instructions for tts, default is None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current descriptions for instructions and optimize_instructions are very brief. To help users understand and use these new parameters effectively, please expand the docstrings to include:

  • A clear explanation of what each parameter does.
  • The expected format or some examples of valid values.
  • The distinction between instructions and optimize_instructions.

Clear documentation is essential for API usability.

@songguocola songguocola deleted the dev_audio_260128 branch January 29, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant