Skip to content

Conversation

@songguocola
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @songguocola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new instructions and optimize_instructions parameters to the update_session method within the qwen3-tts-realtime module. This enhancement allows users to provide specific directives to the Text-to-Speech engine, enabling more refined control and customization of the audio generation process. The changes primarily involve modifying the method signature, updating documentation, and integrating these parameters into the session configuration.

Highlights

  • New Parameters for TTS Session: The update_session method in qwen_tts_realtime now accepts instructions and optimize_instructions as new parameters.
  • Enhanced TTS Configuration: These new parameters allow for more granular control over the Text-to-Speech generation process by passing specific instructions to the session.
  • Docstring Updates: The docstring for update_session has been updated to include descriptions for the newly added instructions and optimize_instructions parameters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for instructions and optimize_instructions parameters in the QwenTtsRealtime class. The changes are well-contained and correctly add the new functionality. I have one suggestion regarding code style to ensure consistency with the existing codebase.

Comment on lines +239 to +242
if instructions is not None:
self.config['instructions'] = instructions
if optimize_instructions is not None:
self.config['optimize_instructions'] = optimize_instructions

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the surrounding code, please use double quotes for dictionary keys instead of single quotes. The rest of the file uses double quotes for dictionary keys (e.g., line 238), and maintaining a consistent style improves readability. PEP 8 advises picking a quote style and sticking to it.

Suggested change
if instructions is not None:
self.config['instructions'] = instructions
if optimize_instructions is not None:
self.config['optimize_instructions'] = optimize_instructions
if instructions is not None:
self.config["instructions"] = instructions
if optimize_instructions is not None:
self.config["optimize_instructions"] = optimize_instructions

@songguocola songguocola deleted the dev_audio_260128 branch January 28, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant