(feat:model/cosyvoice):use new protocol to build websocket connection

[songguocola]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @songguocola, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the audio communication layer by introducing a dedicated WebSocket protocol for audio services. This change provides a more structured and efficient way to handle real-time audio data, particularly for speech synthesis, by abstracting WebSocket interactions into reusable components and integrating them into the existing SpeechSynthesizerV2 functionality.

Highlights

• New WebSocket Protocol Implementation: Introduced AudioWebsocketCallback and AudioWebsocketRequest to establish and manage WebSocket connections for audio services, providing a dedicated layer for real-time audio communication.
• SpeechSynthesizerV2 Integration: The SpeechSynthesizerV2 class has been updated to leverage this new WebSocket protocol for speech synthesis, enabling more robust streaming capabilities and event handling.
• Enhanced Testing: A new test class, TestTtsV2SpeechSynthesizerV2, was added to validate the streaming functionality of the updated speech synthesizer using a mock WebSocket server, ensuring the new protocol works as expected.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/main/java/com/alibaba/dashscope/audio/protocol/AudioWebsocketCallback.java
  • Defines an interface for handling WebSocket lifecycle events (onOpen, onMessage for text/binary, onError, onClose) specifically for audio streams.
• src/main/java/com/alibaba/dashscope/audio/protocol/AudioWebsocketRequest.java
  • Implements okhttp3.WebSocketListener to manage WebSocket connections.
  • Provides methods for connecting to a WebSocket endpoint, sending text and binary messages, and closing the connection.
  • Manages connection state (open/closed) and handles connection timeouts.
• src/main/java/com/alibaba/dashscope/audio/ttsv2/SpeechSynthesizerV2.java
  • Now implements AudioWebsocketCallback to receive events from the new WebSocket request handler.
  • The connect() method has been updated to utilize the new AudioWebsocketRequest for establishing WebSocket connections.
  • Methods like sendTaskMessage(), startSynthesizer(), sendText(), and stopSynthesizer() are modified to interact with the new AudioWebsocketRequest for sending messages.
  • Enhanced error handling and state management related to WebSocket connection and task lifecycle events (task-started, task-finished, task-failed, result-generated).
• src/test/java/com/alibaba/dashscope/TestTtsV2SpeechSynthesizerV2.java
  • New JUnit test file to verify the SpeechSynthesizerV2's streaming capabilities.
  • Uses MockWebServer to simulate WebSocket interactions, testing onOpen, onMessage (text and binary), and onClose events.
  • Asserts correct audio data accumulation during streaming calls, ensuring the integration functions correctly.

Activity

• The pull request was recently opened by songguocola.
• It contains the initial implementation of the new WebSocket protocol for audio.
• No further activity such as comments or reviews has been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new WebSocket protocol for CosyVoice speech synthesis. A critical security vulnerability was identified: API keys could be transmitted over unencrypted connections due to insufficient protocol validation, and sensitive user input (PII) is being logged. Beyond security, the implementation requires improvements in error handling, state management, code clarity, and test robustness, specifically addressing incorrect error logging, state updates, code duplication, and issues in the test setup.