feat(model/qwen3-tts-realtime):optimize_instructions params

[songguocola]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @songguocola, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the QwenTtsRealtimeConfig by refining the optimizeInstructions parameter. The change converts this parameter from a nullable string to a boolean, providing a more explicit and streamlined way to control server-side instruction optimization. This refactoring simplifies the configuration process and improves code clarity for this specific setting.

Highlights

• Parameter Type Change: The optimizeInstructions parameter in QwenTtsRealtimeConfig has been refactored from a String type to a boolean type.
• Default Value Update: The default value for optimizeInstructions is now false, previously it was null.
• Configuration Logic Simplification: The logic for adding OPTIMIZE_INSTRUCTIONS to the configuration map has been updated to directly check the boolean value of optimizeInstructions, setting it to true in the config if the flag is enabled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the optimizeInstructions parameter to use a boolean type, which improves type safety. However, for consistency with other boolean flags in QwenTtsRealtimeConfig like enableTn, I've suggested changing it to the Boolean wrapper type. This allows for more uniform handling of optional parameters across the class. The proposed changes will align its implementation with existing patterns in the codebase.

[gemini-code-assist]

For consistency with other optional boolean parameters in this class, like enableTn (line 48), consider using the Boolean wrapper type instead of the primitive boolean. This allows for a null state, making the parameter handling more uniform throughout the class and aligning with the pattern used for enableTn.

Suggested change

	@Builder.Default boolean optimizeInstructions = false;
	@Builder.Default Boolean optimizeInstructions = false;

[gemini-code-assist]

To align with the suggested change of optimizeInstructions to the Boolean wrapper type, this logic should be updated to check for null. This ensures that the parameter is added to the configuration map only when it has been explicitly set (to either true or false), which is consistent with how other optional parameters like enableTn are handled on lines 89-91.

Suggested change

	if (optimizeInstructions) {
	config.put(QwenTtsRealtimeConstants.OPTIMIZE_INSTRUCTIONS, true);
	}
	if (optimizeInstructions != null) {
	config.put(QwenTtsRealtimeConstants.OPTIMIZE_INSTRUCTIONS, optimizeInstructions);
	}