-
Notifications
You must be signed in to change notification settings - Fork 22
feat(model/qwen3-tts-realtime):support instruct param #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @songguocola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Qwen TTS Realtime functionality by adding support for instruction parameters, which can guide the text-to-speech synthesis process. This provides more control and flexibility for users interacting with the service. Additionally, a small correction was made to a voice name within the audio parameters. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for instructions and optimizeInstructions parameters in the qwen-tts-realtime model configuration. The changes include adding the new fields to QwenTtsRealtimeConfig, corresponding constants, and logic to include them in the configuration payload. Additionally, a minor typo in a voice name (ELDRIC_SAGA to ELDRIC_SAGE) has been corrected.
My review focuses on improving code clarity and ensuring robustness through testing. I've identified that the new feature lacks test coverage, which is a significant risk for regressions. I've also suggested improving a Javadoc comment for better clarity. Addressing these points will improve the quality and maintainability of the code.
| /** instructions for tts, default is null */ | ||
| @Builder.Default String instructions = null; | ||
|
|
||
| /** instructions will optimize on server side, default is null */ | ||
| @Builder.Default String optimizeInstructions = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added parameters instructions and optimizeInstructions are not covered by tests. Please add unit tests in TestQwenTtsRealtime.java to verify that these parameters are correctly serialized and included in the request payload. This is crucial for ensuring the feature works as intended and preventing future regressions.
| /** instructions for tts, default is null */ | ||
| @Builder.Default String instructions = null; | ||
|
|
||
| /** instructions will optimize on server side, default is null */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.