Skip to content

Conversation

@songguocola
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @songguocola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Qwen TTS Realtime functionality by adding support for instruction parameters, which can guide the text-to-speech synthesis process. This provides more control and flexibility for users interacting with the service. Additionally, a small correction was made to a voice name within the audio parameters.

Highlights

  • New Instruction Parameters for Qwen TTS Realtime: Introduced instructions and optimizeInstructions parameters to the QwenTtsRealtimeConfig, allowing users to provide specific instructions for text-to-speech generation and server-side optimization.
  • Typo Correction in Voice Enum: Corrected a minor typo in the AudioParameters enum, changing 'Eldric Saga' to 'Eldric Sage' for one of the voice options.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for instructions and optimizeInstructions parameters in the qwen-tts-realtime model configuration. The changes include adding the new fields to QwenTtsRealtimeConfig, corresponding constants, and logic to include them in the configuration payload. Additionally, a minor typo in a voice name (ELDRIC_SAGA to ELDRIC_SAGE) has been corrected.

My review focuses on improving code clarity and ensuring robustness through testing. I've identified that the new feature lacks test coverage, which is a significant risk for regressions. I've also suggested improving a Javadoc comment for better clarity. Addressing these points will improve the quality and maintainability of the code.

Comment on lines +50 to +54
/** instructions for tts, default is null */
@Builder.Default String instructions = null;

/** instructions will optimize on server side, default is null */
@Builder.Default String optimizeInstructions = null;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The newly added parameters instructions and optimizeInstructions are not covered by tests. Please add unit tests in TestQwenTtsRealtime.java to verify that these parameters are correctly serialized and included in the request payload. This is crucial for ensuring the feature works as intended and preventing future regressions.

/** instructions for tts, default is null */
@Builder.Default String instructions = null;

/** instructions will optimize on server side, default is null */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc for optimizeInstructions is grammatically awkward and could be clearer. A better description would help users understand its purpose. For example: 'Instructions that will be optimized on the server side.'

@kevinlin09 kevinlin09 merged commit 1882931 into dashscope:main Jan 29, 2026
4 checks passed
@songguocola songguocola deleted the dev_audio_2601 branch January 29, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants