Skip to content

refactor: separate network and consensus logic 3/N [governance] #7008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 20 commits into from
Dec 16, 2025
Merged

refactor: separate network and consensus logic 3/N [governance] #7008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
91129d4
refactor: drop dead code with ERROR_TXINDEX_DISABLED_WHEN_GOV_ENABLED
knst Nov 20, 2025
78c6062
refactor: drop unused includes and forward declarations from masterno…
knst Nov 20, 2025
285def6
refactor: use NetHandler to move scheduler & partially network relate…
knst Nov 20, 2025
7e4849a
refactor: inline method CleanOrphanObjects to CGovernanceManager::Req…
knst Nov 20, 2025
e878592
refactor: drop dependency of masternode/sync on governance by moving …
knst Nov 20, 2025
be0be6b
chore: fix clang-format and adjust log messages
knst Nov 21, 2025
eb9607e
refactor: move DEFAULT_SYNC_MEMPOOL form validation.h to masternode/s…
knst Nov 21, 2025
e7f9218
refactor: drop a wrapper RequestGovernanceObjectVotes for a single node
knst Nov 21, 2025
77faacc
refactor: split FetchGovernanceObjectVotes to own member of CGovernan…
knst Nov 21, 2025
8425ca1
fix: reduce scope of ::cs_main during PeerGetRequestedObjectCount
knst Nov 21, 2025
461392e
refactor: move RequestGovernanceObjectVotes to NetGovernance to drop …
knst Nov 22, 2025
7f3d16d
chore: apply clang-format and adjust logs
knst Nov 22, 2025
fa0e173
refactor: add CConnman to NetHandler's ProcessMessage
knst Nov 22, 2025
fc21e51
refactor: move ProcessMessage from CGovernanceManager to NetGovernance
knst Nov 23, 2025
106827c
fmt: clang-format
knst Nov 24, 2025
b9aec50
refactor: split NetGovernance to SyncManager and NetGovernance
knst Dec 12, 2025
9ac269c
refactor: move ProcessMessage from CMasternodeSync to SyncManager
knst Dec 12, 2025
dc08ef4
refactor: break circular dependency of CMasternodeManager over net.h
knst Dec 12, 2025
be62366
refactor: pass connman in constructor of NetHandler's child which nee…
knst Dec 12, 2025
a67300c
fix: multiple CI failures
knst Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,9 @@ BITCOIN_CORE_H = \
dsnotificationinterface.h \
governance/classes.h \
governance/common.h \
governance/governance.h \
governance/exceptions.h \
governance/governance.h \
governance/net_governance.h \
governance/object.h \
governance/signing.h \
governance/validators.h \
Expand Down Expand Up @@ -311,6 +312,7 @@ BITCOIN_CORE_H = \
node/miner.h \
node/minisketchwrapper.h \
node/psbt.h \
node/sync_manager.h \
node/transaction.h \
node/txreconciliation.h \
node/interface_ui.h \
Expand Down Expand Up @@ -508,6 +510,7 @@ libbitcoin_node_a_SOURCES = \
governance/classes.cpp \
governance/exceptions.cpp \
governance/governance.cpp \
governance/net_governance.cpp \
governance/object.cpp \
governance/signing.cpp \
governance/validators.cpp \
Expand Down Expand Up @@ -567,6 +570,7 @@ libbitcoin_node_a_SOURCES = \
node/miner.cpp \
node/minisketchwrapper.cpp \
node/psbt.cpp \
node/sync_manager.cpp \
node/transaction.cpp \
node/txreconciliation.cpp \
node/interface_ui.cpp \
Expand Down
Loading
Loading