Skip to content

Conversation

@gjuric
Copy link

@gjuric gjuric commented Jan 21, 2025

Fixes PHP 8.4 deprecation notices.

To view these notices before this commit, run tests with --display-deprecations flag on PHP 8.4.

Fixes PHP 8.4 deprecation notices.

To view thew notices
@artursreiljans
Copy link
Contributor

Sorry, just noticed that I've created a duplicate pull request (#95).

I think I'd leave mine open however, as it also intends to drop support for older PHP versions that are not compatible with modern syntax.

Anyway, it's kinda funny that we both created same pull requests few hours apart, even though PHP 8.4 was released almost two months ago :)

@gjuric
Copy link
Author

gjuric commented Jan 24, 2025

Thank you, I've forgot to remove the unsupported PHP versions, so I will be closing this one.

@gjuric gjuric closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants