Skip to content

Conversation

@siegfried
Copy link

@siegfried siegfried commented Dec 17, 2021

This PR is related to #22

@siegfried
Copy link
Author

siegfried commented Dec 17, 2021

I'm a little hesitant to modify the current code base even through a few of them are reusable. I presume to reuse them some renaming and updates might be necessary, so I think adding some tests at first might be a good idea, in order to not break current behavior. This is a WIP PR, so please feel free to leave any comment. @daroczig

@siegfried
Copy link
Author

siegfried commented Dec 17, 2021

These functions are using deprecated V1 API. Is there a plan to remove them in favor of V3?

  • binance_ticker_all_prices()
  • binance_ticker_all_books()
  • binance_ticker_24hr()

Also these functions which are fundamental should be migrated easily:

  • binance_ping()
  • binance_time()
  • binance_klines()
  • binance_ticks()
  • binance_trades()
  • binance_depth()
  • binance_exchange_info()

@daroczig

@siegfried
Copy link
Author

Or shall we version the functions according to the API?

@siegfried
Copy link
Author

On a second thoughts we might have to skip the tests requiring authentication until it is possible to have a shared credential for testing. Even though the timestamp can be input as an argument. different credentials would produce different signatures.

@siegfried siegfried marked this pull request as ready for review December 18, 2021 00:02
@siegfried
Copy link
Author

siegfried commented Dec 20, 2021

Now LIMIT orders and MARKET orders work on USDM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant