Full workflow versioning #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Callarisa <albert@diagrid.io>
JoshVanL
requested changes
Jan 14, 2026
JoshVanL
left a comment
JoshVanL
left a comment
There was a problem hiding this comment.
We should update the protos as "NAME_MISSMATCH" is not correct- it should read "VERSION_NOT_AVAILABLE"
task/orchestrator.go
Outdated
Comment on lines
875
to
882
| sequenceNumber := ctx.getNextSequenceNumber() | ||
| stalledAction := &protos.OrchestratorAction{ | ||
| Id: sequenceNumber, | ||
| OrchestratorActionType: &protos.OrchestratorAction_OrchestratorVersionNotRegistered{ | ||
| OrchestratorVersionNotRegistered: &protos.OrchestratorVersionNotRegisteredAction{}, | ||
| }, | ||
| } | ||
| ctx.pendingActions[sequenceNumber] = stalledAction |
There was a problem hiding this comment.
Suggested change
| sequenceNumber := ctx.getNextSequenceNumber() | |
| stalledAction := &protos.OrchestratorAction{ | |
| Id: sequenceNumber, | |
| OrchestratorActionType: &protos.OrchestratorAction_OrchestratorVersionNotRegistered{ | |
| OrchestratorVersionNotRegistered: &protos.OrchestratorVersionNotRegisteredAction{}, | |
| }, | |
| } | |
| ctx.pendingActions[sequenceNumber] = stalledAction | |
| ctx.pendingActions[ctx.getNextSequenceNumber()] = &protos.OrchestratorAction{ | |
| Id: sequenceNumber, | |
| OrchestratorActionType: &protos.OrchestratorAction_OrchestratorVersionNotRegistered{ | |
| OrchestratorVersionNotRegistered: &protos.OrchestratorVersionNotRegisteredAction{}, | |
| }, | |
| } |
Member
Author
There was a problem hiding this comment.
kept sequenceNumber as it's needed twice.
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
workflow-versioning
branch
from
b8bf757 to
35abf3c
Compare
JoshVanL
requested changes
Jan 14, 2026
| return orchestrator, nil | ||
| } else { | ||
| return nil, fmt.Errorf("versioned orchestrator '%s' does not have a latest version registered", es.Name) | ||
| return nil, api.NewUnsupportedVersionError() |
There was a problem hiding this comment.
Do we want to pass the version name to NewUnsupportedVersionError?
Member
Author
There was a problem hiding this comment.
It would be very useful, this error is only used to trigger the ctx.setVersionNotRegistered(), and the action message doesn't have any properties, so it would not be used...
Signed-off-by: Albert Callarisa <albert@diagrid.io>
JoshVanL
approved these changes
Jan 14, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for full workflow versioning.
The public interface in the
TaskRegistrywas already added previously but not fully implemented. This PR adds the remaining changes forAddVersionedOrchestratorNandAddVersionedOrchestratorto work as expected.