Support workflow patching #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Callarisa <albert@diagrid.io>
JoshVanL
requested changes
Nov 25, 2025
backend/orchestration.go
Outdated
|
|
||
| if results.GetPatchMismatch() { | ||
| _ = runtimestate.AddEvent(wi.State, &protos.HistoryEvent{ | ||
| EventId: -1, |
There was a problem hiding this comment.
Unrelated note: we should update Event ID to be optional.
JoshVanL
reviewed
Nov 25, 2025
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
workflow-versioning
branch
from
fb69eac to
fd5db26
Compare
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
|
Can you resolve the conflicts? |
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
workflow-versioning
branch
2 times, most recently
from
3b7cc51 to
ffdb640
Compare
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
workflow-versioning
branch
from
ffdb640 to
0a01e95
Compare
Signed-off-by: Albert Callarisa <albert@diagrid.io>
JoshVanL
requested changes
Jan 5, 2026
backend/executor.go
Outdated
| } | ||
|
|
||
| func (g *grpcExecutor) requireNotStalled(ctx context.Context, id string) error { | ||
| metadata, err := g.backend.GetOrchestrationMetadata(ctx, api.InstanceID(id)) |
There was a problem hiding this comment.
This looks to be very expensive to do on every call (?)
Does this need to be done in the executor, and not in dapr actor?
Member
Author
There was a problem hiding this comment.
Makes sense, I moved to the actors in the dapr/dapr PR, this particular commit: dapr/dapr@fc07ce9
cicoyle
reviewed
Jan 7, 2026
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev> Signed-off-by: Albert Callarisa <albert@acroca.com>
JoshVanL
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the patching as described in the versioning proposal.
Quick summary of the changes added in this PR:
ctx.IsPatched(patchName) boolto ongoing workflowsPendingVersionif the orchestrator find a patch mismatchPendingVersionevent when a patch mismatch is foundstate.IsPendingVersionacordingly