Addition of a getter and setter to lists#971
Open
dantevlobos wants to merge 3 commits intodaphne-project:mainfrom
Open
Addition of a getter and setter to lists#971dantevlobos wants to merge 3 commits intodaphne-project:mainfrom
dantevlobos wants to merge 3 commits intodaphne-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a getter and a setter for the list data structure in DaphneDSL. I am open to changing the names of the functions and also how they operate. I wasn't sure how to call the functions, so I made the names verbose to leave no confusion of what the function does. As for the setter method, I modeled it to be as close as possible to the remove method for lists to increase the chances of the function working as intended.
New Functions:
Exactly how the functions work are written in the documentation for built in functions, Builtin.md.
Tests cases have been written similar to the pre existing tests for lists.