Conversation
| <string name="pref_sync_fblink" translatable="false">pref_sync_fblink</string> | ||
| <string name="pref_sync_fblink_title">Add link to Facebook</string> | ||
| <string name="pref_sync_fblink_summary">Add a link to Facebook to event descriptions.</string> | ||
| <string name="pref_sync_fblink_summary">Add a link to event description on Facebook.</string> |
There was a problem hiding this comment.
Not quite sure about this. Where is the comment made, and what is it about?
There was a problem hiding this comment.
It's in the "Configure Sync Preferences" menu. When the option is checked, it will append a link to the event on facebook.com to the event description, so your change is incorrect. I realize the original string is a little awkward, I don't know how to express it better.
danvratil
left a comment
danvratil
left a comment
There was a problem hiding this comment.
Thanks for the improvements!
Regarding the pref_language_default_value, it's intentionally untranslatable, it's an internal string for configuration that does not appear in the UI.
| <string name="pref_sync_fblink" translatable="false">pref_sync_fblink</string> | ||
| <string name="pref_sync_fblink_title">Add link to Facebook</string> | ||
| <string name="pref_sync_fblink_summary">Add a link to Facebook to event descriptions.</string> | ||
| <string name="pref_sync_fblink_summary">Add a link to event description on Facebook.</string> |
There was a problem hiding this comment.
It's in the "Configure Sync Preferences" menu. When the option is checked, it will append a link to the event on facebook.com to the event description, so your change is incorrect. I realize the original string is a little awkward, I don't know how to express it better.
| <string name="calendar_declined_title">Events I\'m not Attending</string> | ||
| <string name="calendar_tentative_title">Events I May Be Attending</string> | ||
| <string name="calendar_attending_title">Events I\'m Attending</string> | ||
| <string name="calendar_not_responded_title">Unanswered</string> |
There was a problem hiding this comment.
These are the actual calendar names as displayed in the phone calendar, which I'm not sure if I want to change at this point (although I'm grateful that you came up with shorter names :-) ).
There's a plan for one of the next releases to allow users to customize the calendar names, so I think that will be a good point to rename the calendars, but for now let's keep the originals please.
| <string name="nav_configure_calendars">Configure Calendars</string> | ||
| <string name="nav_configure_sync">Configure Sync</string> | ||
| <string name="nav_sync_logs">Sync Logs</string> | ||
| <string name="nav_sync_logs" comment="(Verb) Synchronize the logs">Sync Logs</string> |
There was a problem hiding this comment.
This is actually exactly the wrong meaning – it's the noun. Clicking on this navigation bar entry shows those logs.
| <string name="pref_reminder_0minutes_entry">Right away</string> | ||
| <string name="pref_reminder_0minutes_value" translatable="false">0</string> | ||
| <string name="pref_reminder_5minutes_entry">5 minutes</string> | ||
| <string name="pref_reminder_5minutes_entry">Five minutes</string> |
There was a problem hiding this comment.
I'd argue that using words instead of numbers here makes the menu more cluttered and more difficult to read. It's not prose, but just a settings menu 😉
3 participants
Perhaps
<string name="pref_language_default_value" translatable="false">device</string>should be translatable?