Fix Windows cross-driver relative path cleaning#17
Draft
Conversation
Author
|
@danreeves 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: danreeves <1973559+danreeves@users.noreply.github.com>
Co-authored-by: danreeves <1973559+danreeves@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Doesn't work well with relative path across drivers on Windows
Fix Windows cross-driver relative path cleaning
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cleaning relative paths that cross Windows drives, the library was producing malformed absolute paths with missing backslashes after drive letters.
Problem
Given this input path:
Expected output:
Actual output:
The backslash was missing after
C:, making it an invalid Windows path.Root Cause
When relative navigation (
../../../..) crosses drive boundaries on Windows, the path cleaning algorithm correctly processes the components but can end up with a sequence like[Prefix(C:), Normal("Users"), ...]instead of the required[Prefix(C:), RootDir, Normal("Users"), ...]. WhenPathBufreconstructs this sequence, it producesC:Usersinstead ofC:\Users.Solution
Added Windows-specific logic that detects when a Windows drive prefix component is immediately followed by a normal path component and inserts the missing
RootDircomponent between them. This ensures absolute Windows paths are properly formatted.The fix:
cfg!(windows))Testing
Added comprehensive test coverage including:
Fixes #16.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.