reoganize code in install_hooks for easier maintenance#47
Open
samirnoman wants to merge 1 commit intodanny0838:mainfrom
Open
reoganize code in install_hooks for easier maintenance#47samirnoman wants to merge 1 commit intodanny0838:mainfrom
samirnoman wants to merge 1 commit intodanny0838:mainfrom
Conversation
* put all hooks in a hash variable %hooks so they can be reviewed/modified together * write hooks in a loop over the %hooks hash * print a message if hooks are overwritten * do not install hooks if dry-run is set * TODO: it may be relatively easy to add a safety option to backup hooks if they exist (--backup)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor edit to the function install_hooks which implement these changes (no new functionality is added):
put all hooks in a hash variable %hooks so they can be reviewed/modified together
write hooks in a loop over the %hooks hash
print a message if hooks are overwritten
do not install hooks if dry-run is set
TODO: it may be relatively easy to add a safety option to backup hooks if they exist (--backup)