PR 요청 드립니다. #4
Open
PR 요청 드립니다. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 0.1.4 => 0.2.1
- sensor_tsl2561
- Raspberry Pi 테스트를 위하여 원복.
- 기존 TSL2561을 fork하여 I2C 버전 변경된 부분을 반영.
- 1.4.5 => 1.7.4
- 각 보드별 소스 첨부를 위해 빌드 조정. - Makefile 조정.
- sftp-config.json 추가.
- build.sh를 이용하여 빌드.
- wiringPi 추가.
- beagle 및 raspberry pi 분기.
- 주석 처리된 내용 정리.
- DEBUG define 주석 처리.
Porting/raspberry
Porting/raspberry
Update release
- debug 모드 경고 주석 추가.
- debug 모드 경고 주석 추가.
* 인자값 검사 부분 변경
- RP에서는 테스트 완료. - BBB에서 테스트 필요.
Porting raspberry
- Intel Edison에서는 기존 i2c 모듈로 동작하지 않음.
Contributor
|
Thanks for your contribution, but the scope you modified are too broad to accept at once. Actually, the sensorjs is working on various commercial products. So every pull request must have one specific feature to fix or enhance, therefore we can test with the commercial products. The PR you have requested includes a lot of changes in many parts, so we cannot determine the impact of the PR for the commercial products. If possible, please make a PR with specific and independent feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요. 금년도 ETRI WoT.js 과제를 수행한 네이지 소프트 손준호 입니다.
이번 과제에 적용하기 위해 sensorjs 일부를 수정하여 PR을 요청하오니 확인 부탁드립니다.
감사합니다.