Skip to content

Conversation

@denini08
Copy link

Fix #160

This PR fixes test failures on Windows caused by differences in file paths and line endings.

  • Normalizes error message patterns so they match correctly across platforms.
  • Adjusts line endings handling in tests to accept both \n and \r\n.
  • Updates path checks to use os.sep instead of hardcoded slashes.

These changes make the tests pass on Windows while keeping compatibility with Linux and mac. I’m happy to help, and let me know what you think.

@pgiraud
Copy link
Member

pgiraud commented Aug 25, 2025

Thanks a lot for your contribution. Unfortunately, we don't officially support Windows and we probably won't in a near future. Moreover we don't have any CI running on Windows so even if this fixes an issue, we can't make sure it does and will continue to work in the future.

@denini08
Copy link
Author

Hi @pgiraud

I get that Windows isn’t officially supported. I just thought this change wouldn’t hurt, won’t affect behavior on Linux/macOS, and might help anyone running tests on Windows.

Thanks for considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail on Windows due to path and line ending differences

2 participants