pay-common: add granular SessionState types#199
Open
GianlucaMinoprio wants to merge 2 commits intomasterfrom
Open
pay-common: add granular SessionState types#199GianlucaMinoprio wants to merge 2 commits intomasterfrom
GianlucaMinoprio wants to merge 2 commits intomasterfrom
Conversation
Update SessionState from "pending" | "paid" | "expired" to include: - pending: waiting for deposit - processing: funds received, bridging in progress - completed: funds delivered - expired: session timed out
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update SessionState type to include granular states for better deposit tracking:
pending- waiting for deposit, no funds receivedprocessing- funds received, bridging/swapping in progresscompleted- funds delivered to destinationexpired- session timed outThis replaces the previous "paid" state which didn't distinguish between processing and completed.
Related
Part of daimo-internal PR #1260 (deposit address API)