Open
Conversation
Contributor
thyagopereira
commented
Apr 27, 2021
thyagopereira
commented
- Criação do file só acontece com sudo, trabalhando nisso.
- Avanços estruturais, e de coleta. Me atrasou um pouco a necessidade de lidar com o id de sessão.
danielfireman
requested changes
Apr 27, 2021
crawler.go
Outdated
| page, err := ioutil.ReadAll(resp.Body) | ||
| htmlCode := string(page) | ||
|
|
||
| id := strings.Split(htmlCode, "Constants.viewingSessionId = \"") |
Contributor
There was a problem hiding this comment.
Poderia, por favor, fazer um teste de unidade para essa função? para tornar o teste mais fácil, pode utilizar a bilioteca httptest
danielfireman
requested changes
Apr 28, 2021
danielfireman
requested changes
Apr 30, 2021
Contributor
danielfireman
left a comment
danielfireman
left a comment
There was a problem hiding this comment.
Estamos quase chegando lá! 😄
|
|
||
| // Retorna as url para download de cada planilha em questão | ||
| func requestURL(year, month int) (urlRequests, error) { | ||
| remuIDURL := fmt.Sprint("https://servicos-portal.mpro.mp.br/plcVis/frameset?__report=..%2FROOT%2Frel%2Fcontracheque%2Fmembros%2FremuneracaoMembrosAtivos.rptdesign&anomes=", year, fmt.Sprintf("%02d", month), "&nome=&cargo=&lotacao=") |
Contributor
There was a problem hiding this comment.
Aplicar o mesmo estilo da sugestão abaixo aqui.
danielfireman
approved these changes
May 3, 2021
Contributor
danielfireman
left a comment
danielfireman
left a comment
There was a problem hiding this comment.
Bacana! Favor endereçar os comentários abaixo antes de fazer merge
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| _, err = os.Stat(outputPath) |
Contributor
There was a problem hiding this comment.
colocar esse assinalamento no if abaixo
| var fileName = fmt.Sprintf("%d_%02d_remu.xls", year, month) | ||
| var filePath = fmt.Sprint(outputPath, "/", fileName) | ||
|
|
||
| err = download(request.remunerationURL, filePath, outputPath) |
Contributor
There was a problem hiding this comment.
Colocar esse assinalamento no if abaixo
| var fileName = fmt.Sprintf("%d_%02d_vi.xls", year, month) | ||
| var filePath = fmt.Sprint(outputPath, "/", fileName) | ||
|
|
||
| err = download(request.benefitsURL, filePath, outputPath) |
Contributor
There was a problem hiding this comment.
mover assinalamento para dentro do if abaixo
| Month int `envconfig:"MONTH" required:"true"` | ||
| Year int `envconfig:"YEAR" required:"true"` | ||
| OutputFolder string `envconfig:"OUTPUT_FOLDER" default:"/output"` | ||
| OutputFolder string `envconfig:"OUTPUT_FOLDER" default:"./output"` |
| fileNames := Crawl(month, year, outputPath) | ||
| fileNames, err := Crawl(month, year, outputPath) | ||
| if err != nil { | ||
| os.Exit(1) |
|
|
||
| paths = append(paths, filePath) | ||
| case viURLType: | ||
| var fileName = fmt.Sprintf("%d_%02d_vi.xls", year, month) |
Contributor
There was a problem hiding this comment.
Suggested change
| var fileName = fmt.Sprintf("%d_%02d_vi.xls", year, month) | |
| fileName := fmt.Sprintf("%d_%02d_vi.xls", year, month) |
| paths = append(paths, filePath) | ||
| case viURLType: | ||
| var fileName = fmt.Sprintf("%d_%02d_vi.xls", year, month) | ||
| var filePath = fmt.Sprint(outputPath, "/", fileName) |
Contributor
There was a problem hiding this comment.
Suggested change
| var filePath = fmt.Sprint(outputPath, "/", fileName) | |
| filePath := fmt.Sprint(outputPath, "/", fileName) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.