Skip to content

Linting in spec/phonelib_spec.rb #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stac47 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Linting in spec/phonelib_spec.rb #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/phonelib_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@
['01114552586', 'US'], ['01148209679', 'CA'],
['000000000000000', 'CN'], ['0050016323', 'KR']
]
test_cases.each_with_index do |test_case, i|
test_cases.each do |test_case|
number, country = test_case
phone = Phonelib.parse number, country
expect(phone.valid_for_country?(country)).to be false
Expand Down Expand Up @@ -1478,7 +1478,7 @@
it 'are valid' do
data_file = File.dirname(__FILE__) + '/../data/phone_data.dat'
phone_data = Marshal.load(File.binread(data_file))
phone_data.each do |key, data|
phone_data.each_value do |data|
country = data[:id]
next unless country =~ /[A-Z]{2}/
data[:types].each do |type, type_data|
Expand Down