Open
Conversation
1 similar comment
|
Is there a reason why this isn't getting merged? |
|
Excellent! It was exactly what I am looking for. @tobyhinloopen could you provide minimal documentation on how I can pass a REDIS connection URI instead AUTH, PORT, etc. ? |
Author
|
I think this isn't being merged because IIRC it doesn't actually work. You need a separate Redis connection and it will consume/lock the connection. If you reuse the connection, it will no longer function for other users of the connection. Disclaimer: It has been a while, I forgot the actual details. |
ftischler
approved these changes
May 4, 2021
RodrigoRVSN
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Basically allows you to pass an existing redis client instead of passing host, pass, etc.
client: Redis.createClient()Please review @dabroek . Change suggestions are welcome. I'm not sure how to thoroughly test my change without just copying all tests.