-
Notifications
You must be signed in to change notification settings - Fork 68
Integrate review feedback from #71 + MarkdownPreview in TUI #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3973f14
Add minimal docstrings to MarkdownRenderer methods
cboos 9159e3b
Fix session file count for Markdown output format
cboos a89bfe6
Fix timing lambdas to avoid UnboundLocalError on exception
cboos 31d5ab3
Add error handling for image export file operations
cboos cf9db4d
Update style guide script docstring to mention Markdown output
cboos 54c6bd8
Make CLI --clear-output format-aware with --clear-html backward compat
cboos 6b82fda
Add 'm' shortcut to TUI for opening Markdown session files
cboos 86a81de
Add embedded Markdown viewer to TUI (press 'v')
cboos 9b03632
Add on-demand session file generation to TUI (h/m/v shortcuts)
cboos 14da498
Skip HTML generation in TUI mode (use on-demand via h/m/v)
cboos bffd4fc
Use MarkdownViewer with ToC in embedded viewer (v shortcut)
cboos 3b94efb
Customize MarkdownViewer ToC: 1/3 width, expand 3 levels
cboos 44a1370
Extract shared regex patterns in snapshot serializers
cboos d882876
Remove roman numeral prefixes from MarkdownViewer ToC
cboos e7455d4
Fix ToC label cleaning to handle emoji prefixes
cboos 5b224a1
Add excerpts to sidechain titles and simplify ToC labels
cboos b265688
Add hidden H/M/V shortcuts for force-regenerate in TUI
cboos 80a69cd
Fix type checker errors in tui.py
cboos 6e1e4e1
Document Markdown export and TUI shortcuts in README
cboos 75ac3f6
Hoist strip_error_tags import to module scope in test file
cboos 4849e2d
Unify file extension computation using get_file_extension()
cboos c8f7e87
Simplify output_dir assignment after assert
cboos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? Which is the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean, for the Image Support? Default is embedded base64 as before for HTML, but that's quite annoying for Markdown, so there the default is 'referenced' (command-line help should tell about these defaults).