Skip to content

Update js-yaml to 4.1.1 #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evman182 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −5
Open

Update js-yaml to 4.1.1 #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"debug": "4.4.0",
"execa": "4.1.0",
"istanbul-lib-coverage": "^3.0.0",
"js-yaml": "4.1.0",
"js-yaml": "4.1.1",
Copy link

@jpage-godaddy jpage-godaddy Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also make this more future-proof? Not sure why we have ^ versioning for some but not all dependencies.

Suggested change
"js-yaml": "4.1.1",
"js-yaml": "^4.1.1",

Copy link

@fyodorio fyodorio Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking into account the recent amount of npm supply chain vulnerabilities where unsolicited (and vulnerable) patch versions caused drastic mayhem, I would highly recommend the opposite — switching to strict dependency package versioning.

Copy link

@woody-li woody-li Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fyodorio
I think using strict package version is a good way.
But it requires more timely maintenance to upgrade the dependency versions.

This vulnerability issue was reported at Nov 13, 2025
But the dependency upgrade is still in progress for now (almost 3 months).

"nyc": "15.1.0",
"tinyglobby": "^0.2.14"
},
Expand Down