ci: build libpathrs.so for different Rust versions #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cargo build --crate-type= was stabilised in Rust 1.64, so we need to use the old method of enabling cdylib and staticlib builds for all builds (regardless of the capi feature). This was added by 493cdb2 ("capi: make opt-in via 'capi' feature"), but the lack of a CI hook checking that the build worked meaned that we missed that this was actually broken on Rust 1.63. Debian bookworm still has Rust 1.63 and will be maintained until June 2026 (with LTS lasting until 2028). As such, we should keep our new releases supporting 1.63 until June 2026 just in case someone decides to package libpathrs for Debian oldstable. Fixes: 493cdb2 ("capi: make opt-in via 'capi' feature") Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
We need to make sure that in addition to the actual language usage working with our MSRV (veriied with cargo check by CI) that our scripts also work with the MSRV compiler version. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that in addition to the actual language usage
working with our MSRV (veriied with cargo check by CI) that our scripts
also work with the MSRV compiler version.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com