Skip to content

Fix deprecation in the interpolator #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 1 commit into from
Dec 12, 2025
Merged

Fix deprecation in the interpolator #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Query/Interpolator.php
View file
Open in desktop
Copy link
Contributor

@puzzledpolymath puzzledpolymath Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Away from my desk and reviewing this from my phone, but my first thought when seeing the changes was that the case statement should be:

‘case isset($key) && \array_key_exists($key, $named):’

Copy link
Member Author

@roxblnfk roxblnfk Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree :)

Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static function ($match) use (&$named, &$unnamed, $options) {
$value = \current($unnamed);
\next($unnamed);
return self::resolveValue($value, $options);
case isset($named[$key]) || \array_key_exists($key, $named):
case isset($key) && \array_key_exists($key, $named):
return self::resolveValue($named[$key], $options);
default:
return $match[0];
Expand Down
Loading