smartvmi: add gtest dependency to build test successfully #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, the Nix packaging from this repository assumed that the CMakeLists.txt are modified in such a way that the tests are not built by default. GDATASoftwareAG/smartvmi#154 (comment) requested to remove the behavior. The suggestion to build the CMakeLists.txt from the src folder instead of the top level is great, but after a few tries I did not find the correct derivation settings (e.g., by setting cmakeDir) and chose to just build the tests as well. This commit switches the smartvmi source to a commit without the CMakeLists.txt changes and adds gtest to both vmicore and the plugins (required dependency of the test code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, the Nix packaging from this repository assumed that the CMakeLists.txt are modified in such a way that the tests are not built by default.
GDATASoftwareAG/smartvmi#154 (comment) requested to remove the behavior. The suggestion to build the CMakeLists.txt from the src folder instead of the top level is great, but after a few tries I did not find the correct derivation settings (e.g., by setting cmakeDir) and chose to just build the tests as well. This commit switches the smartvmi source to a commit without the CMakeLists.txt changes and adds gtest to both vmicore and the plugins (required dependency of the test code).