Skip to content

Comments

Dco fix v2#10

Open
ihorman wants to merge 5 commits intocyberfabric:mainfrom
ihorman:dco_fix_v2
Open

Dco fix v2#10
ihorman wants to merge 5 commits intocyberfabric:mainfrom
ihorman:dco_fix_v2

Conversation

@ihorman
Copy link
Contributor

@ihorman ihorman commented Oct 29, 2025

Description

This PR fixes the failing DCO check and updates documentation:

  • CI: replace broken probot/dco@v2 reference with a Bash-based DCO verification workflow (.github/workflows/dco.yml).
  • Docs: add Testing Strategy and Code Review Guidelines.
  • Docs: restructure API documentation and add alternative patterns (REST/GraphQL/gRPC/AsyncAPI).
  • Docs: add PlantUML diagram generation spec.

Commits in PR:

  • 9b4275f ci: replace broken probot/dco with built-in bash DCO check
  • bd130bc Added: Testing Strategy and Code Review Guidelines
  • d3f2d22 Restructure API documentation and add alternative patterns
  • 2ebda9d tiny updates related to REST API guidelines
  • f2937a6 added spec for nice diagram generation in PlantUML format

Type of Change

  • Documentation update
  • New section/guide
  • Bug fix (typo, broken link)
  • Code example improvement
  • Other: CI workflow fix (DCO check)

Checklist

  • Commits are signed off (git commit -s)
  • Changes follow DNA principles
  • Code examples tested (N/A – docs only)
  • Links are valid
  • Self-review completed

Related Issues

Closes #7

Signed-off-by: Ihor Kolodyuk <you@example.com>
Signed-off-by: Ihor Kolodyuk <ihorman@gmail.com>
Signed-off-by: Ihor Kolodyuk <you@example.com>
Signed-off-by: Ihor Kolodyuk <ihorman@gmail.com>
Signed-off-by: Ihor Kolodyuk <you@example.com>
Signed-off-by: Ihor Kolodyuk <ihorman@gmail.com>
Signed-off-by: Ihor Kolodyuk <you@example.com>
Signed-off-by: Ihor Kolodyuk <ihorman@gmail.com>
Signed-off-by: Ihor Kolodyuk <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant