Add Ctrl+D shortcut to stop multiple scans early #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Add Ctrl+D shortcut to stop multiple scans early Co-authored-by: OverSamu <17676511+OverSamu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: OverSamu <17676511+OverSamu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, following #743, in order not to change the current behavior, I propose to detect EOF (Ctrl+D, or Ctrl+Z then Enter on Windows) to interrupt multiple scans started with
--waitscanby saving the pages scanned up to that point.I tested the implementation on Windows 10 and it behaves as I expect.
naps2.console -o "scan.pdf" -n 100 --waitscan --firstnow -v Beginning scan... Starting scan 1 of 100... Scanned page 1. 1 page(s) scanned. Press Enter to scan, or Ctrl+D to stop and save. Starting scan 2 of 100... Scanned page 2. 1 page(s) scanned. Press Enter to scan, or Ctrl+D to stop and save. ^Z Stopping scan and saving... Exporting... Exporting page 1 of 2. Exporting page 2 of 2. Successfully saved PDF file to scan.pdf