Fix console --force overwrite with --split option #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Whoops, I see a problem here in the PDF save operation. I don't think I need to confirm overwrite during the PDF save operation since the overwrite confirmation has already been handled by that point. |
-Used to determine whether to increment the placeholder number.
cyanfish
reviewed
Nov 18, 2023
| [return: NotNullIfNotNull("filePath")] | ||
| public abstract string? Substitute(string? filePath, bool incrementIfExists = true, int numberSkip = 0, | ||
| int autoNumberDigits = 0); | ||
| int autoNumberDigits = 0, bool incrementPlaceholderIfExists = true); |
Owner
There was a problem hiding this comment.
I'd rather not make this logic more complicated - I think it should be possible to re-use the existing incrementIfExists parameter, we just need to double check the callers and make sure everything is going to behave as expected.
cyanfish
force-pushed
the
master
branch
2 times, most recently
from
e1ca63b to
46577c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
Hello. Thought I would take a stab at this one. Please let me know if you think anything else needs be done here.