Merged
Conversation
fix active tab color + fix variable import in build2.less (clean-bordered and -contrasted)
… CSS builder script
Member
|
Thanks a lot @felixhahnweilheim , you've done a really great work! I've only made a very small commit: df48c1b As soon as Humhub v1.15-beta-2 and Dark mode module v1.0.0-beta4 are released I'll release a new version of this Clean Theme module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dark stylesheets (dark.css) to the clean theme. It is meant to work with the upcoming version of the dark mode module.
Related PR: felixhahnweilheim/humhub-dark-mode#9
This PR is only a draft so far and meant as a proof of concept.
The stylesheet dark.css only contains color related CSS. This is achieved by using css-color-extractor: https://github.com/rsanchez/css-color-extractor
Unfortunately this tool does not support CSS variables yet (see rsanchez/css-color-extractor#11). That's why the CSS compiling process is a bit more complex (see the added file build-dark-css.sh).
To do
Screenshot of clean-base (dark):