Support CTA Train Tracker + HACS installation#2
Support CTA Train Tracker + HACS installation#2smcpeck wants to merge 12 commits intocustom-components:masterfrom
Conversation
|
I have removed myself as reviewer, this is not something I can test or maintain. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not stale. Waiting for merge. |
|
@smcpeck did you ever get this up and back running? |
@almighty059 |
|
@smcpeck I'll start using your fork and see if I run into any issues. I'm kind of new to some of the GitHub stuff so I had a question about your reply to the bot marking this "stale". You said that you were "waiting for merge" and I wanted to know how long that takes or what else needs to be done.? |
|
I think the big problem is that nobody really "owns" this custom component. I think if you could start using my fork and verify that things are working as desired, that would be good step to provide some external testing/validation. You could approve this pull request if things checkout after using my fork. To be honest, I don't know who would be the person to pull the trigger on this merge... I don't have a great grasp on the processes and procedures for the HACS community. So I've just been using my own fork and living my happy life. 😃 |
|
@smcpeck great.!! You're nominated. 😂 So I don't have a great grasp on verifying and approving but I definitely know how to let you know if it's working or not. If you let me know the steps in helping you out I will. I was also looking over the code (and I only have basic coding knowledge) there are a couple of changes I would suggest or I'd like to try..
|
|
Thanks for sharing your thoughts, @almighty059 I'm happy to "own" this component. Still not sure how to make the PR not be "stale" and actually get it to be merged. I'm going to poke around on the HA Discord server and see if I can get some guidance. While waiting for that... have you been continuing to use my fork in your setup and having decent functional success? Thanks again! |
|
As I check around on some things, I did find this: https://github.com/custom-components/information It sounds like maybe, since we are able to be deployed now via HACS, there is no need/reason to really try merging these changes into the |

This PR brings in previous work done by @jonochocki to enable a HACS installation.
The more recent work that I've done adds consumption of the Train Tracker API (readme details updated) for a full solution of bus and train times in one integration.
Some tweaks will be needed upon merge (it seems) in order to properly support HACS expectation of which repo contains the code.