Skip to content

Support CTA Train Tracker + HACS installation#2

Open
smcpeck wants to merge 12 commits intocustom-components:masterfrom
smcpeck:master
Open

Support CTA Train Tracker + HACS installation#2
smcpeck wants to merge 12 commits intocustom-components:masterfrom
smcpeck:master

Conversation

@smcpeck
Copy link

@smcpeck smcpeck commented Jan 11, 2022

This PR brings in previous work done by @jonochocki to enable a HACS installation.

The more recent work that I've done adds consumption of the Train Tracker API (readme details updated) for a full solution of bus and train times in one integration.

Some tweaks will be needed upon merge (it seems) in order to properly support HACS expectation of which repo contains the code.

@smcpeck smcpeck requested a review from ludeeus as a code owner January 11, 2022 03:29
@ludeeus ludeeus removed their request for review February 20, 2022 20:26
@ludeeus
Copy link
Contributor

ludeeus commented Feb 20, 2022

I have removed myself as reviewer, this is not something I can test or maintain.
If anyone wants to maintain it hit me up on discord. (Ludeeus#4212)

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Apr 16, 2022
@smcpeck
Copy link
Author

smcpeck commented Apr 21, 2022

Not stale. Waiting for merge.

@almighty059
Copy link

@smcpeck did you ever get this up and back running?

@smcpeck
Copy link
Author

smcpeck commented Aug 30, 2022

@smcpeck did you ever get this up and back running?

@almighty059
I've been using my fork as a custom repository in HACS this whole time. No glaring issues that I've seen.

@almighty059
Copy link

@smcpeck I'll start using your fork and see if I run into any issues. I'm kind of new to some of the GitHub stuff so I had a question about your reply to the bot marking this "stale". You said that you were "waiting for merge" and I wanted to know how long that takes or what else needs to be done.?

@smcpeck
Copy link
Author

smcpeck commented Sep 16, 2022

@almighty059

I think the big problem is that nobody really "owns" this custom component. I think if you could start using my fork and verify that things are working as desired, that would be good step to provide some external testing/validation. You could approve this pull request if things checkout after using my fork.

To be honest, I don't know who would be the person to pull the trigger on this merge... I don't have a great grasp on the processes and procedures for the HACS community. So I've just been using my own fork and living my happy life. 😃

@almighty059
Copy link

@smcpeck great.!! You're nominated. 😂 So I don't have a great grasp on verifying and approving but I definitely know how to let you know if it's working or not. If you let me know the steps in helping you out I will.

I was also looking over the code (and I only have basic coding knowledge) there are a couple of changes I would suggest or I'd like to try..

  1. At 3am there are no buses or maybe very limited buses running and during that time the value of "unknown" is returned. "Unknown" makes it sounds like there's an error so I was thinking of having a value of "Not Schedued" or something similar.
  2. I have also tried using a template to add the suffix of "minute(s)" to the time. I had to use a custom:multiple-entity-row because it wouldn't work with entities. I was also trying to change "DUE" to "APPROACHING" but I'm having problems with my template. I still need to fix that. I have never made a custom card before but I wonder if it's worth trying to make one for this that gives the user the option for things like that.
  3. I've also been experimenting with different ways to pull the updates so there's not a constant pull on the API. The one way I'm trying is I use a toggle switch which I turn on to get updates every 30 seconds. The other way I'm trying is to run a script to pull it whenever I press the UPDATE button. So far they both work but I don't know which I prefer.
  4. I need to fix the timestamp into something that is readable but I'm not worried about that yet because the secondary last-update basically gives me the same info.

Screenshot 2022-09-17 193946

@smcpeck
Copy link
Author

smcpeck commented Jan 12, 2023

Thanks for sharing your thoughts, @almighty059

I'm happy to "own" this component. Still not sure how to make the PR not be "stale" and actually get it to be merged. I'm going to poke around on the HA Discord server and see if I can get some guidance.

While waiting for that... have you been continuing to use my fork in your setup and having decent functional success? Thanks again!

@smcpeck
Copy link
Author

smcpeck commented Jan 12, 2023

As I check around on some things, I did find this: https://github.com/custom-components/information

It sounds like maybe, since we are able to be deployed now via HACS, there is no need/reason to really try merging these changes into the custom_components organization of Home Assistant. Which, I guess, I'm fine with... it would just live in my own little fork and that would be its home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants