-
Notifications
You must be signed in to change notification settings - Fork 2
Fix ci #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix ci #115
Conversation
WalkthroughThe set of changes updates multiple GitHub Actions workflow files to use newer, stable versions of key actions. Across all workflows, the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test.yml (1)
23-23: Update Python version matrix
Removing 3.7 reflects dropped support. Consider quoting all versions consistently (e.g.,'3.8','3.9','3.10') to avoid YAML parsing ambiguities.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/auto_merge.yml(1 hunks).github/workflows/docs.yml(1 hunks).github/workflows/release.yml(1 hunks).github/workflows/test.yml(3 hunks)
🔇 Additional comments (9)
.github/workflows/auto_merge.yml (1)
10-11: Modernize GitHub Actions versions
The updates toactions/checkout@v4andahmadnassri/action-dependabot-auto-merge@v2.6align with the rest of the CI workflows. Ensure thataction-dependabot-auto-merge@v2.6is compatible with your usage ofsecrets.DEPENDABOT_AUTOMERGE..github/workflows/docs.yml (1)
11-13: Bump actions versions for docs workflow
Upgradingactions/checkouttov4andactions/setup-pythontov5ensures consistency with other workflows. Confirm thatsetup-python@v5supports your specifiedpython-version: 3.8..github/workflows/release.yml (3)
3-6: Restrict release workflow to published events
Changing the trigger to onlyrelease.types: [published]prevents runs on draft or prerelease events. Verify if you also needcreatedor other release event types for your process.
11-14: Upgrade checkout and Python setup actions
Bumping toactions/checkout@v4andactions/setup-python@v5aligns with your other workflows. Ensure that using Python 3.8 here meets your project’s minimum support requirements.
21-21: Update PyPI publish action to stable release
Switching topypa/gh-action-pypi-publish@release/v1follows the new versioning scheme. Confirm thatrelease/v1is the intended tag and is actively maintained..github/workflows/test.yml (4)
9-13: Align versions in lint job
Upgradingactions/checkouttov4andactions/setup-pythontov5for the lint job maintains consistency across jobs.
25-28: Upgrade checkout and setup for pytest job
Bumping toactions/checkout@v4andactions/setup-python@v5is consistent. Ensure the matrix substitution${{ matrix.python-version }}resolves correctly for all version formats.
38-43: Upgrade checkout and setup for coverage job
Parallel to other jobs, updating toactions/checkout@v4andactions/setup-python@v5is spot on.
48-50: Update Codecov action and token usage
Switching tocodecov/codecov-action@v5and addingtoken: ${{ secrets.CODECOV_TOKEN }}is required by the new action. Ensure thatCODECOV_TOKENis set in the repository’s secrets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 466 475 +9
=========================================
+ Hits 466 475 +9
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary by CodeRabbit