-
Notifications
You must be signed in to change notification settings - Fork 118
added semantic versioning and automated releases #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
onefloid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nicolasbisurgi, grand job! I left a few comments in the code.
|
|
||
| ## Release Process | ||
|
|
||
| TM1Py uses **automated nightly releases** with semantic versioning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be beneficial to trigger automatic release manually. Imagine we have a small correction that we can deliver immediately, or we have time during the day to check the pipeline and don't want to wait overnight. Maybe we should talk about an automated release workflow that happens regularly every night
| "pytz", | ||
| 'requests_negotiate_sspi; platform_system=="Windows"', | ||
| "mdxpy>=1.3.1", | ||
| "networkx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
networkx is no longer a dependency. See #1301.
| # Placeholder for future unit tests | ||
| # Uncomment when unit tests are available | ||
| # - name: Run unit tests | ||
| # run: | | ||
| # pip install -e .[dev] | ||
| # pytest Tests/unit/ -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a section “How to contribute” in docs/how-to-contribute.md. I think we should move these new great explanations to that file and put a reference to it here in CONTRIBUTING.MD. What do you think?
Implemented the same release management than in RushTI and as discussed here