Skip to content

iOS13 Player Crash Fix #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
normand1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

iOS13 Player Crash Fix #468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cb2f76
return MPRemoteCommandHandlerStatus from target action selectors
normand1 Feb 22, 2020
6401f7e
undo unrelated change
normand1 Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Recast/PlayerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class PlayerViewController: ViewController {

// MARK: - Player Controls

@objc func playPauseButtonWasPressed(_ sender: UIButton) {
@objc func playPauseButtonWasPressed(_ sender: UIButton) -> MPRemoteCommandHandlerStatus {
if player.rate == 0.0 {
if currentTime == duration {
currentTime = 0.0
Expand All @@ -222,6 +222,7 @@ class PlayerViewController: ViewController {
} else {
player.pause()
}
return .success
}

private func skip(seconds: Double) {
Expand All @@ -233,12 +234,14 @@ class PlayerViewController: ViewController {
})
}

@objc func skipBackButtonWasPressed(_ sender: UIButton) {
@objc func skipBackButtonWasPressed(_ sender: UIButton) -> MPRemoteCommandHandlerStatus {
skip(seconds: -30)
return .success
}

@objc func skipForwardButtonWasPressed(_ sender: UIButton) {
@objc func skipForwardButtonWasPressed(_ sender: UIButton) -> MPRemoteCommandHandlerStatus {
skip(seconds: 30)
return .success
}

@objc func timeSliderDidChange(_ sender: UISlider) {
Expand Down