Enable multi-arch build #7
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables multi-architecture Docker image builds by adding QEMU emulation support to the GitHub Actions workflow. This allows the workflow to build images for both AMD64 and ARM64 architectures.
- Adds QEMU setup step using
docker/setup-qemu-action@v3to enable cross-platform builds - Updates the build command to target both AMD64 and ARM64 Linux platforms
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Build/Push to GitHub Container Registry | ||
| run: | ||
| make push-multiarch PULL_BASE_REF=$(git describe --tags --abbrev=0) REGISTRY_NAME=ghcr.io/ctrliq BUILD_PLATFORMS="linux amd64 amd64 -amd64; linux arm64 arm64 -arm64" |
There was a problem hiding this comment.
The BUILD_PLATFORMS parameter format appears incorrect. Based on the build.make file (line 162), the format expects space-separated fields per platform entry: "os arch buildx_platform suffix base_image addon_image".
The current format has duplicated "amd64 amd64" and "arm64 arm64" which doesn't match the expected pattern. According to the example in build.make (line 135), it should be "linux amd64" (os and arch) or "linux amd64 amd64 -amd64" when specifying buildx_platform and suffix.
Consider using: BUILD_PLATFORMS="linux amd64; linux arm64"
| make push-multiarch PULL_BASE_REF=$(git describe --tags --abbrev=0) REGISTRY_NAME=ghcr.io/ctrliq BUILD_PLATFORMS="linux amd64 amd64 -amd64; linux arm64 arm64 -arm64" | |
| make push-multiarch PULL_BASE_REF=$(git describe --tags --abbrev=0) REGISTRY_NAME=ghcr.io/ctrliq BUILD_PLATFORMS="linux amd64; linux arm64" |
No description provided.