-
Notifications
You must be signed in to change notification settings - Fork 0
Backend Test Refactor #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results Summary286 tests - 61 286 ✅ - 61 9s ⏱️ -1s Results for commit 57e94c3. ± Comparison against base commit 4b50976. This pull request removes 347 and adds 286 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…ix invalid api key errors
manyuagashe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback was conducted in detail over certain logical issues and typing problems over Slack. No more feedback for PR, LGTM, approved.
Refactored tests to use utils instead of hardcoding values. Reduced test line count by half (10k -> 5k)
Changes:
from_modelandto_modelas required functions for default impl of utils.hash_andverify_password to a utils file instead of part of police service for police entityhttp/assertions.pyhttp/test_templates.pygeo.pyExtras:
MappedAsDataclassto have better constructor typingreset_devto satisfy constructornpm iinstead ofnpm ciinpost_create.shto not have to install from clean every container rebuildCloses #118