Skip to content

Conversation

@MasonMines2006
Copy link
Collaborator

Implemented high-level search bar for finding elements in three tables

Changes:

TableList.tsx

  • Params: party/location/student input data & callback functions for updating them in root page
  • Filters data based on input typed into search result.
  • For party and location: filters by if query is within formatted address.
  • For Student: filters by first name, last name, or email

Staff page

  • Added global search bar
  • Imported mock data that is saved in use state
  • Created use state for filtered data that is given by search bar and inputted into tables.

Closes #82

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry. To clarify the ticket, we are looking for one table wide search per table, instead of one global table search. Although the current impl of the global search kinda makes it act like a single table search, implementing it per table will make it more performant. There is also a built in Tanstack Table feature that we want to use (globalFilterFn), which makes it optimized for the library. Lmk if you have any questions, and sorry to have made you waste effort :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all the changes in
/police/page
EmbeddedMap
PartyList
StudentInfo
and StudentTable
are formatting/whitespace changes. I ask that these be reverted back to main to avoid making merge conflicts. This can be easily done by running this command
git checkout origin/main -- path-to-file-to-revert

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results Summary

347 tests  ±0   347 ✅ ±0   9s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit ae08181. ± Comparison against base commit 2d0d974.

♻️ This comment has been updated with latest results.

@naasanov naasanov merged commit ead27d4 into main Dec 2, 2025
2 checks passed
@naasanov naasanov deleted the mason-table-wide-search branch December 2, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table Wide Search

3 participants