-
Notifications
You must be signed in to change notification settings - Fork 0
Mason table wide search #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sorry. To clarify the ticket, we are looking for one table wide search per table, instead of one global table search. Although the current impl of the global search kinda makes it act like a single table search, implementing it per table will make it more performant. There is also a built in Tanstack Table feature that we want to use (globalFilterFn), which makes it optimized for the library. Lmk if you have any questions, and sorry to have made you waste effort :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe all the changes in
/police/page
EmbeddedMap
PartyList
StudentInfo
and StudentTable
are formatting/whitespace changes. I ask that these be reverted back to main to avoid making merge conflicts. This can be easily done by running this command
git checkout origin/main -- path-to-file-to-revert
Implemented high-level search bar for finding elements in three tables
Changes:
TableList.tsx
Staff page
Closes #82