Feat/coord interface/integration by gabrielhan23 · Pull Request #526 · csmberkeley/csm_web

gabrielhan23 · 2025-09-03T05:21:42Z

No description provided.

* initial table * table css work * table css work * front end table searching and select data logic * front end table searching and select data logic * search filter works * im done fr now fixed select glitch and styled input and buttons slightly * finished front end table * functions and dropdown basics * touchups for front end filtering integration and css * copy button works and table header structure * fixed filtering bugs and css for action buttons * fixed weird double copy bug * fixed filter copy bug * finished coord interface --------- Co-authored-by: Heidi Chan <heidi.chan@berkeley.edu>

…integration

…eley/csm_web into feat/coord-interface/integration

This reverts commit 5bc7521.

cypress · 2025-09-07T22:29:37Z

csm_web Run #437

Run Properties: Passed #437 • 5e053f3201: Feat/coord interface/integration (#526)

Project	`csm_web`
Branch Review	`master`
Run status	`Passed #437`
Run duration	`03m 34s`
Commit	`5e053f3201: Feat/coord interface/integration (#526)`
Committer	`gabrielhan23`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`84`
View all changes introduced in this branch ↗︎

Copilot

Pull Request Overview

This PR implements a coordinator interface integration that allows coordinators to view and manage students and mentors in their courses. The implementation includes backend API endpoints for coordinator data access, frontend React components for displaying tabular data with filtering capabilities, and routing updates to support the new coordinator views.

Adds backend API endpoints for coordinator authentication and data retrieval
Implements React-based coordinator interface with search and filtering functionality
Integrates coordinator view access through existing course interface

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
csm_web/scheduler/views/coord.py	New coordinator API views with authentication and data serialization
csm_web/scheduler/serializers.py	Added coordinator-specific serializers and docstring updates
csm_web/scheduler/models.py	Added mentor family field, section day_time property, and pylint disable comments
csm_web/frontend/src/components/coord_interface/*.tsx	React components for coordinator table interface with filtering and search
csm_web/frontend/src/utils/queries/coord.tsx	API query utilities for coordinator data
csm_web/scheduler/urls.py	URL routing for coordinator endpoints
csm_web/frontend/src/components/App.tsx	Added coordinator routes to main app

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-07T22:42:56Z

csm_web/frontend/src/utils/queries/coord.tsx

+
+export const getCoordData = async (courseId: number, isStudents: boolean) => {
+  // query disabled when id undefined
+  if (isNaN(courseId!)) {


The non-null assertion operator ! is used on courseId which is already typed as number. This assertion is unnecessary and could mask potential runtime errors if courseId is actually undefined.

Suggested change

if (isNaN(courseId!)) {

if (isNaN(courseId)) {

Copilot · 2025-09-07T22:42:56Z

csm_web/frontend/src/components/coord_interface/CoordTable.tsx

+    setSearch([]);
+    setSelected([]);
+    setAllSelected(false);
+    const checkbox = document.getElementById("checkcheck") as HTMLInputElement;


The element ID 'checkcheck' doesn't match the actual checkbox ID which should be 'checkcheck' (from CheckBox component). This should be consistent with the CheckBox component's ID generation pattern.

Copilot · 2025-09-07T22:42:57Z

csm_web/frontend/src/components/coord_interface/CoordTable.tsx

+      if (field in row) {
+        const value = row[field as keyof typeof row];
+        if (filter.includes("+")) {
+          return value != null ? value.toString() >= filter.slice(0, -1) : false;
+        }
+        return value != null ? value.toString().includes(filter) : false;
+      }


String comparison using >= for filtering (line 131) will perform lexicographic comparison rather than numeric comparison. For numeric fields like numUnexcused or numStudents, this should use Number(value) >= Number(filter.slice(0, -1)).

Copilot · 2025-09-07T22:42:57Z

csm_web/frontend/src/components/coord_interface/CoordTable.tsx

+            </tr>
+          </thead>
+          <tbody>
+            {searchData.length === 0 ? <div className="no-data">No data found...</div> : null}


A <div> element cannot be a direct child of <tbody>. This should be wrapped in a <tr><td colSpan={columnCount}> structure to be valid HTML.

Suggested change

{searchData.length === 0 ? <div className="no-data">No data found...</div> : null}

{searchData.length === 0 ? (

<tr>

<td className="no-data" colSpan={6}>No data found...</td>

</tr>

) : null}

Copilot · 2025-09-07T22:42:57Z

csm_web/scheduler/views/coord.py

+    )
+    if not is_coord:
+        raise PermissionDenied(
+            "You do not have permission to view the coordinator view."


The error message references 'view the coordinator view' which is redundant and unclear. It should be more specific, such as 'You do not have permission to delete sections for this course.'

Suggested change

"You do not have permission to view the coordinator view."

"You do not have permission to delete sections for this course."

gabrielhan23

lgtm

heidi-chann · 2026-01-29T00:43:18Z

Coord Interface beta in the works!

heidi-chann

Nicely Gabriel!

gabrielhan23 and others added 15 commits February 27, 2025 01:10

mentor and student view APIs

fe2f8e1

API cleanup and speedup

82f4d24

delete API finished, error checking implemented for all APIs

a9e7909

completed backend APIs

2b64cd3

initial table

2545926

fixed table view, created coord query, fixed backend APIs

88bbbfd

Merge remote-tracking branch 'origin/main' into feat/coord-interface/…

de0e92e

…integration

Merge branch 'feat/coord-interface/integration' of github.com:csmberk…

419da40

…eley/csm_web into feat/coord-interface/integration

fixed css

1b576ff

add migrations

0202361

ran precommit

5bc7521

Revert "ran precommit"

2615724

This reverts commit 5bc7521.

fixed precommit issues

6df658e

firefox cypress test add install firefox

474cc40

gabrielhan23 requested a review from Copilot September 7, 2025 22:30

This comment was marked as outdated.

Sign in to view

spelling mistake

56de0bb

gabrielhan23 requested review from ElaineShu0312, Copilot, edwardneo, isabellaalps and smartspot2 September 7, 2025 22:41

Copilot AI reviewed Sep 7, 2025

View reviewed changes

edwardneo and others added 5 commits September 8, 2025 22:25

Update cypress.yml

3fc59c7

Update Cypress workflow checks

8622f05

fix migrations + less containers for cypress test

93afd08

trying new image

822da46

coord intereface changes so far

63a08c9

elspherical force-pushed the feat/coord-interface/integration branch 2 times, most recently from 11ffca1 to 63a08c9 Compare November 18, 2025 02:53

Update Cypress to 15.6.0

8bd7b61

gabrielhan23 requested review from elspherical and heidi-chann January 29, 2026 00:33

gabrielhan23 commented Jan 29, 2026

View reviewed changes

heidi-chann approved these changes Jan 29, 2026

View reviewed changes

gabrielhan23 merged commit 5e053f3 into master Jan 29, 2026
13 checks passed

gabrielhan23 deleted the feat/coord-interface/integration branch January 29, 2026 00:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/coord interface/integration#526

Feat/coord interface/integration#526
gabrielhan23 merged 22 commits intomasterfrom
feat/coord-interface/integration

gabrielhan23 commented Sep 3, 2025

Uh oh!

cypress bot commented Sep 7, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 7, 2025

Uh oh!

Copilot AI Sep 7, 2025

Uh oh!

Copilot AI Sep 7, 2025

Uh oh!

Copilot AI Sep 7, 2025

Uh oh!

Copilot AI Sep 7, 2025

Uh oh!

gabrielhan23 left a comment

Uh oh!

heidi-chann commented Jan 29, 2026

Uh oh!

heidi-chann left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-            {searchData.length === 0 ? <div className="no-data">No data found...</div> : null}
+            {searchData.length === 0 ? (
+              <tr>
+                <td className="no-data" colSpan={6}>No data found...</td>
+              </tr>
+            ) : null}

	"You do not have permission to view the coordinator view."
	"You do not have permission to delete sections for this course."

Conversation

gabrielhan23 commented Sep 3, 2025

Uh oh!

cypress bot commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

csm_web Run #437

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

gabrielhan23 left a comment

Choose a reason for hiding this comment

Uh oh!

heidi-chann commented Jan 29, 2026

Uh oh!

heidi-chann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cypress bot commented Sep 7, 2025 •

edited

Loading