Conversation
Passing run #214 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
…n students are dropped pre-commit fixes fix merge conflict
smartspot2
requested changes
Feb 16, 2024
Member
smartspot2
left a comment
smartspot2
left a comment
There was a problem hiding this comment.
At the moment, this doesn't actually fix the issue, since the mentor could still have left attendances blank when the student drops the section; we should only delete attendances if they're actually in the future. This would require some additional checking for attendances on the day of the drop, to check whether the user dropped the section after the section time or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When students are dropped, they lose their attendances for the current day, even if their attendance has already been taken. This change makes it so that attendances for the day are only deleted when the section is later in the day (i.e. attendance has not been taken)