Draft
Conversation
smartspot2
reviewed
Mar 14, 2023
csm_web/scheduler/views/user.py
Outdated
| if is_private is not None: | ||
| user.is_private = is_private | ||
| user.save() | ||
| return Response(status=status.HTTP_201_CREATED) |
Member
There was a problem hiding this comment.
Ideally, this shouldn't be a 201 CREATED, since you haven't actually created anything. Likely a 200 OK or a ``202 ACCEPTED` would likely fit better.
- refactored `userinfo` route to update user profile - created userprofile url to get a user's profile with an `user_id` - more correct logic!
smartspot2
requested changes
Mar 16, 2023
Member
smartspot2
left a comment
smartspot2
left a comment
There was a problem hiding this comment.
The diff is dominated by whitespace (EOL) changes; I'd recommend trying to resolve this before merging, as it'll make the actual diff a lot harder to view on GitHub.
Perhaps look at git documentation on line endings, or look at line ending configuration in your editor, and tweak configuration settings until modifications to files do not cause all line endings to be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.