Update formatted number string to int parsing to fix different locales#436
Open
whizz wants to merge 2 commits intocryptosharks131:v1.11.0from
Open
Update formatted number string to int parsing to fix different locales#436whizz wants to merge 2 commits intocryptosharks131:v1.11.0from
whizz wants to merge 2 commits intocryptosharks131:v1.11.0from
Conversation
|
it could be a problem in locales like some European countries. |
Owner
|
Could cause an issue with negative numbers like inbound fees. |
Author
|
Updated to also work with negative numbers, though it does not seem to be used for inbound fees |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper function
intcomma()usestoLocaleString(), but the reversetoInt()blindly assumes comma as a thousands separator and tries to remove just commas. In my locale, the thousand separator is space, so the functionality silently breaks. It parses "10 000" as 10. This fix addresses it by removing anything other than digits.