-
Notifications
You must be signed in to change notification settings - Fork 35
Feature: Locally reproducible builds #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR updates pom.xml to enable reproducible builds by adding Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pom.xml (1)
16-50: Add explicitmaven-resources-plugindeclaration to use the pinned version property.The
mvn-resources.versionproperty is defined but never applied to any plugin configuration. Without an explicit plugin declaration, Maven will use the default resources plugin version from the local Maven distribution, undermining the reproducible-builds goal. Add the plugin declaration to pin the version.🔧 Proposed fix
<plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-deploy-plugin</artifactId> <version>${mvn-deploy.version}</version> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-resources-plugin</artifactId> + <version>${mvn-resources.version}</version> + </plugin>
Closes #106.