hash-functions: fix the definition of hash trees#389
Open
multun wants to merge 1 commit intocrypto101:masterfrom
Open
hash-functions: fix the definition of hash trees#389multun wants to merge 1 commit intocrypto101:masterfrom
multun wants to merge 1 commit intocrypto101:masterfrom
Conversation
Member
|
I think there are two competing definitions out there, both are in use, they just disagree about which direction the arrows point. |
Contributor
Author
|
It's not just about the direction of the arrow, as I understand it, the current definition implies each node only references a single ancestor. I fact, I don't even think the patented merkle tree matches this definition, as each node hashes multiple ancestors (or children, depending on the direction of the arrows) In practice, hash tree nodes often reference multiple nodes (git's directory nodes reference multiple files, git commits reference a tree object and the previous commit). I'd rather stick with the terminology of the hash tree wikipedia page, so people don't get confused if they look it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.