fix(client-async): Harden USK datehint resume and cancel handling#1080
fix(client-async): Harden USK datehint resume and cancel handling#1080
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 188461b14d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Carry the watchdog-cancel marker in DateHintTerminalCallback and restore it when rebuilding datehint phase state during resume. Add regression coverage to verify watchdog cancellation survives phase rebuild across resume.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8346f183ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| retryOnStallCancel = false; | ||
| completedBeforePhaseRestore = true; |
There was a problem hiding this comment.
When a persistent request restarts and a terminal callback arrives before onResume() rebuilds activeDateHintPhase (awaitingPhaseRestore path), this block forces retryOnStallCancel to false. In that timing window, a watchdog-triggered CANCELLED failure is forwarded immediately even if retry budget remains, so stalled datehint phases that should get one retry fail permanently after restart.
Useful? React with 👍 / 👎.
|
1 participant
Summary
USKInserterdatehint terminal callback handling for restart/resume windows so terminal events are not lost while phase state is being rebuiltUSKInserterTestwith regression coverage for resume race windows, transitioned-state forwarding, watchdog behavior, and cancel-vs-retry guard pathsHow to test
./gradlew test --tests '*USKInserterTest'./gradlew testNotes
release/2(as requested).bugfix/usk-datehint-resume-retry-guards