feat: add export_languages support in the config file by katerina20 · Pull Request #985 · crowdin/crowdin-cli

katerina20 · 2026-02-09T04:28:52Z

No description provided.

codecov · 2026-02-09T04:33:35Z

Codecov Report

❌ Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.32%. Comparing base (079c871) to head (f655e3c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...om/crowdin/cli/properties/PropertiesWithFiles.java	28.58%	4 Missing and 1 partial ⚠️
...m/crowdin/cli/commands/actions/DownloadAction.java	90.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #985      +/-   ##
============================================
+ Coverage     65.30%   65.32%   +0.03%     
- Complexity     1679     1686       +7     
============================================
  Files           244      244              
  Lines          6881     6897      +16     
  Branches       1046     1051       +5     
============================================
+ Hits           4493     4505      +12     
- Misses         1790     1795       +5     
+ Partials        598      597       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Adds export_languages support to the CLI configuration so downloads can be restricted to a configured subset of target languages (optionally further filtered by excludeLanguageIds).

Changes:

Introduces export_languages config key and maps it onto PropertiesWithFiles.
Updates DownloadAction to compute target languages using CLI args, export_languages, and excluded languages.
Adds a DownloadActionTest covering the export_languages + exclude-languages interaction and extends the test properties builder API.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/main/java/com/crowdin/cli/properties/PropertiesBuilder.java	Adds `EXPORT_LANGUAGES` config key constant.
src/main/java/com/crowdin/cli/properties/PropertiesWithFiles.java	Adds `exportLanguages` field and populates it from config.
src/main/java/com/crowdin/cli/commands/actions/DownloadAction.java	Uses `export_languages` (when no `--language` args) to decide build target languages; refactors language resolution into a helper.
src/test/java/com/crowdin/cli/properties/NewPropertiesWithFilesUtilBuilder.java	Adds `setExportLanguages(...)` to simplify test setup.
src/test/java/com/crowdin/cli/commands/actions/DownloadActionTest.java	Adds a test case for configured export languages with excluded languages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T08:02:45Z

src/test/java/com/crowdin/cli/properties/NewPropertiesWithFilesUtilBuilder.java

+    public NewPropertiesWithFilesUtilBuilder setExportLanguages(List<String> exportLanguages) {
+        this.pb.setExportLanguages(exportLanguages);
+        return this;
+    }


setExportLanguages(...) mutates the underlying PropertiesWithFiles, but buildToString() (used to generate a config file in tests) doesn’t serialize export_languages. This makes the builder inconsistent and will silently drop the setting when someone uses setExportLanguages(...).buildToString() to craft a config-based test. Consider updating buildToString() to include export_languages when present (and ensure formatting matches the existing config text conventions).

added the param to buildToString() function for tests

src/test/java/com/crowdin/cli/commands/actions/DownloadActionTest.java

Copilot · 2026-02-10T08:02:46Z

src/main/java/com/crowdin/cli/properties/PropertiesWithFiles.java

                .map(FileBean.CONFIGURATOR::buildFromMap)
                .collect(Collectors.toList()));
            props.setPseudoLocalization(PseudoLocalization.CONFIGURATOR.buildFromMap(PropertiesBuilder.getMap(map, PSEUDO_LOCALIZATION)));
+            PropertiesBuilder.setPropertyIfExists(props::setExportLanguages, map, EXPORT_LANGUAGES, List.class);


export_languages is loaded as a raw List via setPropertyIfExists(..., List.class) and assigned to a List<String> field. If the config contains non-string items (e.g., numbers), this will pass the type check but later fail with a ClassCastException when iterating in DownloadAction. Consider adding a dedicated helper to validate/convert a list of strings (similar to getListOfMaps) or explicitly validating elements here to throw a ValidationException with a clear message.

Suggested change

PropertiesBuilder.setPropertyIfExists(props::setExportLanguages, map, EXPORT_LANGUAGES, List.class);

Object exportLanguagesObj = map.get(EXPORT_LANGUAGES);

if (exportLanguagesObj instanceof List<?>) {

List<?> rawList = (List<?>) exportLanguagesObj;

List<String> validatedExportLanguages = new ArrayList<>(rawList.size());

for (Object item : rawList) {

if (!(item instanceof String)) {

throw new IllegalArgumentException(

"Property '" + EXPORT_LANGUAGES + "' must be a list of strings"

);

}

validatedExportLanguages.add((String) item);

}

props.setExportLanguages(validatedExportLanguages);

}

added check for list of strings

Copilot · 2026-02-10T08:02:46Z

src/main/java/com/crowdin/cli/properties/PropertiesWithFiles.java

            props.setPseudoLocalization(PseudoLocalization.CONFIGURATOR.buildFromMap(PropertiesBuilder.getMap(map, PSEUDO_LOCALIZATION)));
+            PropertiesBuilder.setPropertyIfExists(props::setExportLanguages, map, EXPORT_LANGUAGES, List.class);
        }


There’s no test exercising parsing of the new export_languages field from an actual config map/file (i.e., via the PropertiesBuilder pipeline). The added DownloadActionTest sets exportLanguages directly on the bean, so a regression in config parsing would go unnoticed. Consider adding a properties-building test that writes export_languages into a config file and asserts it ends up on PropertiesWithFiles (and/or affects the build request).

created a test

src/test/java/com/crowdin/cli/commands/actions/DownloadActionTest.java

feat: Add export_languages support in the config file

f60b6c7

katerina20 requested a review from andrii-bodnar February 9, 2026 04:33

andrii-bodnar requested a review from Copilot February 10, 2026 07:57

Copilot started reviewing on behalf of andrii-bodnar February 10, 2026 07:58 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

address comments

f655e3c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add export_languages support in the config file#985

feat: add export_languages support in the config file#985
katerina20 wants to merge 2 commits intomainfrom
feat/export-lang

katerina20 commented Feb 9, 2026

Uh oh!

codecov bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

katerina20 Feb 18, 2026

Uh oh!

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

katerina20 Feb 18, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

katerina20 Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-            PropertiesBuilder.setPropertyIfExists(props::setExportLanguages, map, EXPORT_LANGUAGES, List.class);
+            Object exportLanguagesObj = map.get(EXPORT_LANGUAGES);
+            if (exportLanguagesObj instanceof List<?>) {
+                List<?> rawList = (List<?>) exportLanguagesObj;
+                List<String> validatedExportLanguages = new ArrayList<>(rawList.size());
+                for (Object item : rawList) {
+                    if (!(item instanceof String)) {
+                        throw new IllegalArgumentException(
+                            "Property '" + EXPORT_LANGUAGES + "' must be a list of strings"
+                        );
+                    }
+                    validatedExportLanguages.add((String) item);
+                }
+                props.setExportLanguages(validatedExportLanguages);
+            }

Conversation

katerina20 commented Feb 9, 2026

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

katerina20 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

katerina20 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

katerina20 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Feb 9, 2026 •

edited

Loading