mocha + chai added#1
Open
pumano wants to merge 5 commits intocrowdbrew:developmentfrom
pumano:development
Open
mocha + chai added#1pumano wants to merge 5 commits intocrowdbrew:developmentfrom pumano:development
pumano wants to merge 5 commits intocrowdbrew:developmentfrom
pumano:development
Conversation
lolmaus
requested changes
Nov 25, 2016
Member
lolmaus
left a comment
lolmaus
left a comment
There was a problem hiding this comment.
-
Please do as described in readme:
yarn add -D ember-cli-mocha ember g ember-cli-mocha -
Also please add custom Mocha reporter:
yarn add -D https://github.com/lolmaus/ember-cli-mocha-reporter.git#patch-1
vyorkin
suggested changes
Nov 25, 2016
package.json
Outdated
| { | ||
| "name": "crowdbrew-frontend", | ||
| "version": "0.0.0", | ||
| "version": "0.0.1", |
There was a problem hiding this comment.
a minor thing, but according to semver it should be 0.1.0:
http://semver.org/#how-should-i-deal-with-revisions-in-the-0yz-initial-development-phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.