feat: configurable environment path#95
Open
tenstad wants to merge 2 commits intocrossplane-contrib:mainfrom
Open
feat: configurable environment path#95tenstad wants to merge 2 commits intocrossplane-contrib:mainfrom
tenstad wants to merge 2 commits intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Amund Tenstad <github@amund.io>
Signed-off-by: Amund Tenstad <github@amund.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related to #82 and https://crossplane.slack.com/archives/C08BBMDCH7W/p1769759797425119?thread_ts=1769438184.689339&cid=C08BBMDCH7W
When loading multiple EnvironmentConfig resources directly into the environment context at the root level, conflicts will occur if they overlap in structure. They can also easily conflict with keys used in patch-and-transform:
I suggest adding
toFieldPathto configure where in the environment to put the referenced resources. Using it as shown below, the composition above would end up with the environment{foo: {name: foo}, bar: {name: bar}, name: baz}instead of just{name: baz}.Another alternative is to create the EnvironmentConfigs in such a way that they wont conflict (which you would still have to do when loading multiple EnvironmentConfigs with a single label selector). It however tightly binds the EnvironmentConfig content to the composition where it is used, instead of just containing the raw data:
I have: