Don't count statistics for failed connections#2
Open
jchampio wants to merge 1 commit intocrossbario:masterfrom
Open
Don't count statistics for failed connections#2jchampio wants to merge 1 commit intocrossbario:masterfrom
jchampio wants to merge 1 commit intocrossbario:masterfrom
Conversation
Failed connection items often show up in the result JSON with junk data (zero or negative timing values, etc.), which throws off the overall statistics. Don't add a connection's stats to the overall Result unless that connection succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed connection items often show up in the result JSON with junk data (zero or negative timing values, etc.), which throws off the overall statistics. This patch keeps track of failed connections and excludes them from the stats.
For example, before this patch I would see output like this: