Add windows/arm64 support, ensure unsupported platforms see a compile error#20
Closed
cesaref wants to merge 2 commits intocrill-dev:mainfrom
Closed
Add windows/arm64 support, ensure unsupported platforms see a compile error#20cesaref wants to merge 2 commits intocrill-dev:mainfrom
cesaref wants to merge 2 commits intocrill-dev:mainfrom
Conversation
triplef
reviewed
Jan 22, 2025
| #define CRILL_32BIT 1 | ||
| #define CRILL_ARM_32BIT 1 | ||
| #elif defined (__arm64__) | ||
| #elif defined (__arm64__) || defined (_M_ARM64) |
There was a problem hiding this comment.
While we’re at it would be great to add support for Android with __aarch64__ as well (see docs).
Suggested change
| #elif defined (__arm64__) || defined (_M_ARM64) | |
| #elif defined (__arm64__) || defined (__aarch64__) || defined (_M_ARM64) |
Contributor
|
Hi @cesaref I checked out your PR today and it's good stuff, I would like to merge it but GitHub says "This branch cannot be rebased due to conflicts". I did resolve the conflict that GitHub flagged, which resulted in a commit on your branch, but somehow GitHub still thinks there's a conflict. Can you resolve it? Once you do I'm happy to merge this PR as-is. Thanks! |
Contributor
|
Alright, I had another look — I have no idea why GitHub doesn't want to automatically merge this PR, all changes seem straightforward. I just applied them manually instead so I'm closing this PR. Thanks again for contributing these fixes!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some updates to support building on windows/arm64.
The tests were previously failing as it was passing through an empty implementation for the memcpy functions, so i've altered these to give a compile error if this happens.
On windows with C++20 enabled, the tests pass on both x64 and arm64 (going via the __cpp_lib_atomic_ref codepath)