Skip to content

Add windows/arm64 support, ensure unsupported platforms see a compile error#20

Closed
cesaref wants to merge 2 commits intocrill-dev:mainfrom
cesaref:main
Closed

Add windows/arm64 support, ensure unsupported platforms see a compile error#20
cesaref wants to merge 2 commits intocrill-dev:mainfrom
cesaref:main

Conversation

@cesaref
Copy link

@cesaref cesaref commented Jan 6, 2025

I've added some updates to support building on windows/arm64.

The tests were previously failing as it was passing through an empty implementation for the memcpy functions, so i've altered these to give a compile error if this happens.

On windows with C++20 enabled, the tests pass on both x64 and arm64 (going via the __cpp_lib_atomic_ref codepath)

#define CRILL_32BIT 1
#define CRILL_ARM_32BIT 1
#elif defined (__arm64__)
#elif defined (__arm64__) || defined (_M_ARM64)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we’re at it would be great to add support for Android with __aarch64__ as well (see docs).

Suggested change
#elif defined (__arm64__) || defined (_M_ARM64)
#elif defined (__arm64__) || defined (__aarch64__) || defined (_M_ARM64)

@triplef triplef mentioned this pull request Apr 11, 2025
@timuraudio
Copy link
Contributor

Hi @cesaref I checked out your PR today and it's good stuff, I would like to merge it but GitHub says "This branch cannot be rebased due to conflicts". I did resolve the conflict that GitHub flagged, which resulted in a commit on your branch, but somehow GitHub still thinks there's a conflict. Can you resolve it? Once you do I'm happy to merge this PR as-is. Thanks!

@timuraudio
Copy link
Contributor

Alright, I had another look — I have no idea why GitHub doesn't want to automatically merge this PR, all changes seem straightforward. I just applied them manually instead so I'm closing this PR. Thanks again for contributing these fixes!!

@timuraudio timuraudio closed this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants