Open
Conversation
nromito
reviewed
Dec 23, 2024
Collaborator
There was a problem hiding this comment.
Nit: can you revert the formatting changes given you're not touching this file outside of those?
Contributor
Author
There was a problem hiding this comment.
Done. I've removed the commit related to formatting changes
673162e to
ddfe814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding DevContainer support, we can utilize a Linux-based build environment, which allows us to operate independently of Xcode and avoids the use of Darwin/macOS-specific flags. This would better reflect the build performed in CI
With current build on Mac: