Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added more details in the me.ReadMe solution file, but to reiterate, the cache portion is theoretically working code, but lacks unit tests and I have not created integration tests across the whole thing. Ideally I'd like a few more days to refine, expand, and tinker; but given the stated goals of the test I think it's a good reflection of a couple days' thought and about 8 hours of work. I need Sunday for chores and a little down time before the next week of work, so I am submitting in its current state.
I look forward to getting your thoughts and having the chance to talk about the whys and decisions made when working through the challenge.